[PATCH] enable build support without systemd compatibility libraries - quoting

[Martin Vidner]

On Wed, Sep 03, 2014 at 11:27:56AM +0200, Umut Tezduyar Lindskog wrote:
> On Tue, Sep 2, 2014 at 12:10 PM, Simon McVittie
> <simon.mcvittie at collabora.co.uk> wrote:
> > On 02/09/14 08:02, Umut Tezduyar Lindskog wrote:
> >>      PKG_CHECK_MODULES(SYSTEMD,
> >>          [libsystemd-login >= 32, libsystemd-daemon >= 32, libsystemd-journal >= 32],
> >>          have_systemd=yes,
> >> -        have_systemd=no)
> >> +        PKG_CHECK_MODULES(SYSTEMD,
> >> +            [libsystemd >= 209],
> >> +            have_systemd=yes,
> >> +            have_systemd=no))
> >
> > This looks reasonable, but is "underquoted" (the rule of thumb should be
> > one pair of [] per pair of ()).
> 
> I didn't understand what you are referring. Could you please explain
> it? I am looking at the parenthesises and don't see anything missing.

See this section of the autoconf manual:
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/M4-Quotation.html

So I think it sould be quoted like this: (not tested)

    PKG_CHECK_MODULES([SYSTEMD],
        [libsystemd-login >= 32, libsystemd-daemon >= 32, libsystemd-journal >= 32],
        [have_systemd=yes],
        PKG_CHECK_MODULES([SYSTEMD],
            [libsystemd >= 209],
            [have_systemd=yes],
            [have_systemd=no]))

-- 
Martin Vidner, Cloud & Systems Management Team
http://en.opensuse.org/User:Mvidner

Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20140908/da59e17d/attachment.sig>