[PATCH] activation: set children oom_score_adj to 0
simon.mcvittie at collabora.co.uk
Wed Jun 8 16:06:52 UTC 2016
On 08/06/16 01:54, WaLyong Cho wrote:
> If dbus is running as systemd service, dbus daemon is running with
> oom_score_adj -900 by OOMScoreAdjust=-900. And children will also have
> same value with dbus daemon.
> To avoid this, set the child itself values after fork () to 0.
Thanks, I've attached your patch to the bug
<https://bugs.freedesktop.org/show_bug.cgi?id=32851> and reviewed it
there. I think there are two relatively minor things that still need fixing:
* not failing to compile if glibc lacks O_CLOEXEC (or
clarifying why such versions don't matter any more);
* not provoking compiler warnings for the unused result of write()
Please see the bug for more details, and send any further patches or
messages on this topic there.
We prefer to receive bug reports and patches via Bugzilla, so we have a
record of status, reviews etc. that doesn't get lost and isn't broken
into months by the mailing list archive. (This is not the same
convention as projects like the Linux kernel - their trade-offs are not
the same as ours.)
Collabora Ltd. <http://www.collabora.com/>
More information about the dbus