[PATCH] Use STANDBY command to set standby time, not IDLE

[Martin Pitt]

Hey Philip,

> -      /* ATA8: 7.18 IDLE - E3h, Non-Data */
> -      UDisksAtaCommandInput input = {.command = 0xe3, .count = data->ata_pm_standby};
> +      /* ATA8: 7.18 STANDBY - E2h, Non-Data */
> +      UDisksAtaCommandInput input = {.command = 0xe2, .count = data->ata_pm_standby};

I came across the AT Attachment 8 - ATA/ATAPI Command Set draft at e. g.
http://www.t10.org/t13/docs2005/D1699r1b-ATA8-ACS.pdf, and that only describes
E3h, "The IDLE command allows the host to place the device in the Idle mode and
also set the Standby timer.", which seems to be what we actually want here. E2h
says "This command causes the device to enter the Standby mode." which sounds
like "immediate".

The "ata-pm-standby" property is only defined to specify the timeout, setting
the timeout should not put the file into immediate standby.

So it seems to me that the current code is right, and this patch would
change the behaviour to an unintended one?

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/devkit-devel/attachments/20140226/2b2966fe/attachment.pgp>