[PATCH] Use STANDBY command to set standby time, not IDLE

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/26/2014 5:18 AM, Martin Pitt wrote:
> I came across the AT Attachment 8 - ATA/ATAPI Command Set draft at
> e. g. http://www.t10.org/t13/docs2005/D1699r1b-ATA8-ACS.pdf, and
> that only describes E3h, "The IDLE command allows the host to place
> the device in the Idle mode and also set the Standby timer.", which
> seems to be what we actually want here. E2h says "This command
> causes the device to enter the Standby mode." which sounds like
> "immediate".
> 
> The "ata-pm-standby" property is only defined to specify the
> timeout, setting the timeout should not put the file into immediate
> standby.
> 
> So it seems to me that the current code is right, and this patch
> would change the behaviour to an unintended one?

Now that I re-read that I think you are right.  I was under the
impression that there was a second timer for entering idle mode and
that's what the IDLE command set,  but it seems that they both set the
standby timer and there is no way to control the idle timer.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTDfyhAAoJEI5FoCIzSKrwnMIIAKBVQQ47ig9ltrFFc5qUCQ/y
W0zfXyubwAb2YTczsu5LvXggiLKGEQm0gsbUi6EuSALRp4n+NrHNTMXq+MIbwy2Q
jo2TprDRTOot9nX4iTnyDbhGB4yfyyN1Dtu7cAvf4cjyv+/TBt7nA5h2ZOe3So+6
UEv7TWzm2476gwAHaG4xsBwiWYgfzrR2cmlkukDsuhSrcSq2qaREMjtCGgJxdVPx
puWWJt7pl57WJHlTOrSYt8Xk2LWPPkQ4I1YWSPeBzsUYwtzr1/C19m8Tqg5EW4oZ
3bm+tiKOh/m5Q7xMJ+DoUXp4HHkVy/sV1bFD0EUX4diPv15EdiSDDa62JHeLt68=
=GGtc
-----END PGP SIGNATURE-----