[PATCH 2/2] dim: Fix SC2231
Daniel Vetter
daniel.vetter at ffwll.ch
Thu Dec 13 08:36:11 UTC 2018
In dim line 976:
for patch in $dir/*; do
^-- SC2231: Quote expansions in this for loop glob to prevent wordsplitting, e.g. "$dir"/*.txt .
Apparently the shellcheck I have is newer than the one we use for
build testing on gitlab.
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
dim | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dim b/dim
index 369ae0846b81..70939ff9abee 100755
--- a/dim
+++ b/dim
@@ -973,7 +973,7 @@ function dim_apply_branch
cat > $file
git mailsplit -b -o$dir $file > /dev/null
- for patch in $dir/*; do
+ for patch in "$dir"/*; do
if ! apply_patch $patch "$@"; then
rv=1
fi
--
2.20.0.rc1
More information about the dim-tools
mailing list