[PATCH 2/2] dim: Fix SC2231

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Thu Dec 13 12:29:22 UTC 2018


Quoting Daniel Vetter (2018-12-13 10:36:11)
> In dim line 976:
>         for patch in $dir/*; do
>                      ^-- SC2231: Quote expansions in this for loop glob to prevent wordsplitting, e.g. "$dir"/*.txt .
> 
> Apparently the shellcheck I have is newer than the one we use for
> build testing on gitlab.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  dim | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dim b/dim
> index 369ae0846b81..70939ff9abee 100755
> --- a/dim
> +++ b/dim
> @@ -973,7 +973,7 @@ function dim_apply_branch
>         cat > $file
>         git mailsplit -b -o$dir $file > /dev/null
>  
> -       for patch in $dir/*; do
> +       for patch in "$dir"/*; do

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Does as the machine tells.

Regards, Joonas


More information about the dim-tools mailing list