[RFC] dim: Stop committer from casually pushing uAPI changes

[Daniel Vetter]

On Fri, Nov 16, 2018 at 3:01 PM Joonas Lahtinen
<joonas.lahtinen at linux.intel.com> wrote:
>
> Somebody casually changing the uAPI headers with no consideration
> to the agreed upon rules seems to be a more frequent problem than
> at least I would like it to be.
>
> Might be worthy to condense a checklist to the warning message,
> or require some Link: tags with # comments?
>
> eg. Link: http://patchwork.example.com/1821 # userspace
>
> Comments, thoughts?

Sounds like a good idea. Good enough for sure that we should discuss
it on dri-devel, together with a documentation update for
drm-uapi.rst. For drm overall one tricky bit is spotting new
properties, probably a too hard nut to crack :-/
-Daniel
>
> Regards, Joonas
> ---
>  dim | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/dim b/dim
> index 3d6548568b56..410369fe2e40 100755
> --- a/dim
> +++ b/dim
> @@ -1512,6 +1512,22 @@ function check_maintainer
>                         echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
>                         rv=1
>                 fi
> +               if i915_uapi_files=$(git diff-tree --no-commit-id --name-only -r $commit | \
> +                       grep -v "^\(include/uapi/drm/i915\)") && [[ -n "$i915_uapi_files" ]]; then
> +                       echo -e "The following i915 uAPI header files were modified:\n"
> +                       echo "i915_uapi_files"
> +                       echo -e "\nConfirm you have appropriate Acked-by from maintainers."
> +                       rv=1
> +               fi
> +               # TODO: Could be used in other DRM branches, too?
> +               if drm_uapi_files=$(git diff-tree --no-commit-id --name-only -r $commit | \
> +                       grep -v "^\(include/uapi/drm/\)") && [[ -n "$drm_uapi_files" ]]; then
> +                       echo -e "The following DRM uAPI header files were modified:\n"
> +                       echo "$drm_uapi_files"
> +                       echo -e "\nConfirm that the changes conform to the DRM uAPI requirements:"
> +                       echo -e "\nhttps://www.kernel.org/doc/html/latest/gpu/drm-uapi.html#open-source-userspace-requirements"
> +                       rv=1
> +               fi
>         fi
>
>         return $rv
> --
> 2.17.2
>
> _______________________________________________
> dim-tools mailing list
> dim-tools at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch