[RFC] dim: Stop committer from casually pushing uAPI changes
joonas.lahtinen at linux.intel.com
Fri Nov 16 14:01:18 UTC 2018
Somebody casually changing the uAPI headers with no consideration
to the agreed upon rules seems to be a more frequent problem than
at least I would like it to be.
Might be worthy to condense a checklist to the warning message,
or require some Link: tags with # comments?
eg. Link: http://patchwork.example.com/1821 # userspace
dim | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/dim b/dim
index 3d6548568b56..410369fe2e40 100755
@@ -1512,6 +1512,22 @@ function check_maintainer
echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
+ if i915_uapi_files=$(git diff-tree --no-commit-id --name-only -r $commit | \
+ grep -v "^\(include/uapi/drm/i915\)") && [[ -n "$i915_uapi_files" ]]; then
+ echo -e "The following i915 uAPI header files were modified:\n"
+ echo "i915_uapi_files"
+ echo -e "\nConfirm you have appropriate Acked-by from maintainers."
+ # TODO: Could be used in other DRM branches, too?
+ if drm_uapi_files=$(git diff-tree --no-commit-id --name-only -r $commit | \
+ grep -v "^\(include/uapi/drm/\)") && [[ -n "$drm_uapi_files" ]]; then
+ echo -e "The following DRM uAPI header files were modified:\n"
+ echo "$drm_uapi_files"
+ echo -e "\nConfirm that the changes conform to the DRM uAPI requirements:"
+ echo -e "\nhttps://www.kernel.org/doc/html/latest/gpu/drm-uapi.html#open-source-userspace-requirements"
More information about the dim-tools