[PATCH] dim: set magic fdo cookie push-option on git push

[Daniel Stone]

Hi,

On Tue, 6 Aug 2019 at 11:58, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On Tue, 6 Aug 2019 at 11:52, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > I think a
> >
> > function dim_push
> > {
> > git push $DRY_RUN $dim_fdo_cookie $@
> > }
> >
> > Would be really nice refactor. Except for the 1 case where we use $DRY
> > and have a reason.
> >
> I agree that minimising the duplicated is a plus, yet dim_push already exists:
>
> function dim_push
> {
>     dim_push_branch $(git_current_branch) "$@"
> }
>
> Regardless, the patch covers _all_ the "git push" instances in DIM and is:
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

I haven't taken a close look at dim lately, but Emil's comment sounds
like a good one. With that, this is (with my repo admin hat on):
Acked-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel