[PATCH] dim: set magic fdo cookie push-option on git push

[Daniel Vetter]

On Tue, Aug 6, 2019 at 12:58 PM Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
> On Tue, 6 Aug 2019 at 11:52, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> >
> > On Tue, Aug 6, 2019 at 12:50 PM Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > >
> > > On Tue, Aug 6, 2019 at 12:42 PM Jani Nikula <jani.nikula at intel.com> wrote:
> > > >
> > > > Make it possible for the server side git pre-receive hook to determine
> > > > the client is dim and refuse the push otherwise.
> > > >
> > > > Obviously it's possible to set the push-option manually on the git
> > > > command line as well, but there's really no plausible denial in that
> > > > case.
> > > >
> > > > Cc: Daniel Stone <daniel at fooishbar.org>
> > > > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > > > Cc: Emil Velikov <emil.l.velikov at gmail.com>
> > > > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> > [stupid gmail]
> >
> > I think a
> >
> > function dim_push
> > {
> > git push $DRY_RUN $dim_fdo_cookie $@
> > }
> >
> > Would be really nice refactor. Except for the 1 case where we use $DRY
> > and have a reason.
> >
> I agree that minimising the duplicated is a plus, yet dim_push already exists:
>
> function dim_push
> {
>     dim_push_branch $(git_current_branch) "$@"
> }
>
> Regardless, the patch covers _all_ the "git push" instances in DIM and is:
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Hm right, would need to name it internal_push or so, also to avoid it
becoming a new subcmd.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch