[PATCH] dim: pull-request: Make sure the commits in the range are checked

Daniel Vetter daniel at ffwll.ch
Fri Aug 9 09:06:25 UTC 2019


On Thu, Aug 08, 2019 at 05:26:31PM +0200, Maxime Ripard wrote:
> From: Maxime Ripard <mripard at kernel.org>
> 
> Following the recent discussion and the fact that commits can be part of a
> pull request without the PR sender being notified (but only the recipient),
> let's make sure both ends are notified if there's such commits.
> 
> Signed-off-by: Maxime Ripard <mripard at kernel.org>

lgtm, Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

I'll wait for Jani to have a look too, then I think we can apply this.
-Daniel

> ---
>  dim | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dim b/dim
> index 4efeed63d374..2ae4c3937932 100755
> --- a/dim
> +++ b/dim
> @@ -2075,6 +2075,7 @@ function dim_pull_request
>  
>  		repo="drm-intel"
>  	else
> +		checkpatch_commit_push_range 1 "$upstream..$branch"
>  		tag=$(tag_name "$branch")
>  		gitk --first-parent "$branch" ^$upstream &
>  		tag_branch $tag $branch
> -- 
> 2.21.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dim-tools mailing list