[PATCH] dim: pull-request: Make sure the commits in the range are checked

[Jani Nikula]

On Fri, 09 Aug 2019, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Thu, Aug 08, 2019 at 05:26:31PM +0200, Maxime Ripard wrote:
>> From: Maxime Ripard <mripard at kernel.org>
>> 
>> Following the recent discussion and the fact that commits can be part of a
>> pull request without the PR sender being notified (but only the recipient),
>> let's make sure both ends are notified if there's such commits.

I'm not sure I understand that. Looking at the patch, it's simply, "Run
checkpatch and friends on pull request." Is there more to it?

The same checks should already have been run *before* pushing the
commits to the repository. There's not much you can do at this stage if
you're working on a non-rebasing branch. But at least you can say sorry
in advance...

Regardless, I don't mind the additional checks,

Acked-by: Jani Nikula <jani.nikula at intel.com>


>> 
>> Signed-off-by: Maxime Ripard <mripard at kernel.org>
>
> lgtm, Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>
> I'll wait for Jani to have a look too, then I think we can apply this.
> -Daniel
>
>> ---
>>  dim | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/dim b/dim
>> index 4efeed63d374..2ae4c3937932 100755
>> --- a/dim
>> +++ b/dim
>> @@ -2075,6 +2075,7 @@ function dim_pull_request
>>  
>>  		repo="drm-intel"
>>  	else
>> +		checkpatch_commit_push_range 1 "$upstream..$branch"
>>  		tag=$(tag_name "$branch")
>>  		gitk --first-parent "$branch" ^$upstream &
>>  		tag_branch $tag $branch
>> -- 
>> 2.21.0
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center