[PATCH] dim: pull-request: Make sure the commits in the range are checked

[Maxime Ripard]

Hi Jani,

On Fri, Aug 09, 2019 at 12:26:00PM +0300, Jani Nikula wrote:
> On Fri, 09 Aug 2019, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Thu, Aug 08, 2019 at 05:26:31PM +0200, Maxime Ripard wrote:
> >> From: Maxime Ripard <mripard at kernel.org>
> >>
> >> Following the recent discussion and the fact that commits can be part of a
> >> pull request without the PR sender being notified (but only the recipient),
> >> let's make sure both ends are notified if there's such commits.
>
> I'm not sure I understand that. Looking at the patch, it's simply, "Run
> checkpatch and friends on pull request." Is there more to it?

This follows the drm-misc-next last PR where I've sent a PR holding
some bad patches that were pushed without using dim and didn't notice
until Dave tried to apply the PR.

> The same checks should already have been run *before* pushing the
> commits to the repository. There's not much you can do at this stage if
> you're working on a non-rebasing branch. But at least you can say sorry
> in advance...

Yes, that was the point, to at least be aware of it and revert /
appologize before sending the PR.

> Regardless, I don't mind the additional checks,
>
> Acked-by: Jani Nikula <jani.nikula at intel.com>

Thanks!

I'm not sure what the committer rights are on dim though, can I push
that patch, or should I wait for someone to pick it up?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dim-tools/attachments/20190812/8562f2c6/attachment.sig>