[PATCH] dim: Do not check Link presence during pull request.
Daniel Vetter
daniel at ffwll.ch
Thu Sep 12 18:52:42 UTC 2019
On Wed, Sep 11, 2019 at 04:36:23PM -0700, Rodrigo Vivi wrote:
> dim should only check commits from author during push.
> Not during pull requests like this.
>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
I think the below is what we actually want.
-Daniel
diff --git a/dim b/dim
index 70262b60d513..9a56fab4f811 100755
--- a/dim
+++ b/dim
@@ -2080,7 +2080,7 @@ function dim_pull_request
repo="drm-intel"
else
- checkpatch_commit_push_range 1 "$upstream..$branch"
+ checkpatch_commit_push_range 1 "$upstream..$branch" --first-parent
tag=$(tag_name "$branch")
gitk --first-parent "$branch" ^$upstream &
tag_branch $tag $branch
> ---
> dim | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dim b/dim
> index 70262b60d513..504ed40dd3b8 100755
> --- a/dim
> +++ b/dim
> @@ -2080,7 +2080,7 @@ function dim_pull_request
>
> repo="drm-intel"
> else
> - checkpatch_commit_push_range 1 "$upstream..$branch"
> + checkpatch_commit_push_range 0 "$upstream..$branch"
> tag=$(tag_name "$branch")
> gitk --first-parent "$branch" ^$upstream &
> tag_branch $tag $branch
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dim-tools
mailing list