[PATCH] dim: Do not check Link presence during pull request.

[Rodrigo Vivi]

On Thu, Sep 12, 2019 at 08:52:42PM +0200, Daniel Vetter wrote:
> On Wed, Sep 11, 2019 at 04:36:23PM -0700, Rodrigo Vivi wrote:
> > dim should only check commits from author during push.
> > Not during pull requests like this.
> > 
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> I think the below is what we actually want.
> -Daniel
> 
> diff --git a/dim b/dim
> index 70262b60d513..9a56fab4f811 100755
> --- a/dim
> +++ b/dim
> @@ -2080,7 +2080,7 @@ function dim_pull_request
>  
>  		repo="drm-intel"
>  	else
> -		checkpatch_commit_push_range 1 "$upstream..$branch"
> +		checkpatch_commit_push_range 1 "$upstream..$branch" --first-parent
>  		tag=$(tag_name "$branch")
>  		gitk --first-parent "$branch" ^$upstream &
>  		tag_branch $tag $branch

I will hold on this and test this approach next time I see this and send v2...

> > ---
> >  dim | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/dim b/dim
> > index 70262b60d513..504ed40dd3b8 100755
> > --- a/dim
> > +++ b/dim
> > @@ -2080,7 +2080,7 @@ function dim_pull_request
> >  
> >  		repo="drm-intel"
> >  	else
> > -		checkpatch_commit_push_range 1 "$upstream..$branch"
> > +		checkpatch_commit_push_range 0 "$upstream..$branch"
> >  		tag=$(tag_name "$branch")
> >  		gitk --first-parent "$branch" ^$upstream &
> >  		tag_branch $tag $branch
> > -- 
> > 2.20.1
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> dim-tools mailing list
> dim-tools at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools