reminder: review of maintainer-tools patches is mandatory

[Sumit Semwal]

Hi Jani,

Apologies on this - I understand the review part as well, you're right.

Just to give you context: This patch was a quick response to Daniel's ask
to update the documentation over IRC. I didn't know the process for this,
and assuming gitlab, created a PR. By the time I could offer Daniel to send
a patch, he had merged the PR.

Irrespective, I will take care going forward. Apologies again.

Best,
Sumit.




On Wed, Jan 13, 2021 at 7:01 PM Jani Nikula <jani.nikula at intel.com> wrote:

>
> Hi Sumit, I just noticed commit 3ed2489ca753 ("Update repositories.rst
> for current drm-misc maintainers") in the maintainer-tools repository.
>
> The change appears to have been pushed without first sending the patch
> to the dim-tools mailing list, and apparently without review.
>
> Regardless of how trivial or minor the change appears to be, review is
> mandatory. For that to happen, posting to the mailing list is mandatory.
>
> Please see CONTRIBUTING.rst in the repository.
>
> ---
>
> As to the change, the review, given the chance, would have been that the
> change is not enough. We still seem to have Sean's email in the dim
> script.
>
>
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dim-tools/attachments/20210113/fa3c38dc/attachment.htm>