[RESEND] An inquiry about DRM Driver for Samsung SoC Exynos4.

[Inki Dae]

Hi, Dave.

> -----Original Message-----
> From: Dave Airlie [mailto:airlied at gmail.com]
> Sent: Monday, October 03, 2011 7:17 PM
> To: Inki Dae
> Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org;
> kyungmin.park at samsung.com
> Subject: Re: [RESEND] An inquiry about DRM Driver for Samsung SoC Exynos4.
> 
> >
> > We would look forward to your comments. thank you.
> 
> I think the only thing I can see wanting changing at this point is to
> add padding to the
> offset ioctl.
> 
> struct drm_samsung_gem_map_off {
>         unsigned int handle;
>         uint64_t offset;
> };
> 
> just add an unsigned int pad; between the two members so the 64-bit
> fields get natively aligned.
> 

Ok, get it. I will add the padding. thank you.

> >
> >> I still dislike the samsung_drm_ everywhere, just because no other
> >> driver does this, but if it helps with backtraces in the future maybe
> >> its okay.
> >>
> >
> > Ok, get it. we would consider using 'exynos' instead of 'samsung'
> seriously
> > if you don't want 'samsung' prefix and then with your comments, the
> change
> > would be done on PATCH v6.
> 
> Yeah I think it would be a good idea to just go with exynos, and then
> I'll merge V6 into -next.
> 
> Dave.

Ok, get it. I will send patch V6 soon. thank you for your review.