[Bug 67530] VDPAU state tracker reports wrong codec level
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Wed Aug 7 03:49:04 PDT 2013
https://bugs.freedesktop.org/show_bug.cgi?id=67530
--- Comment #5 from Christian König <deathsimple at vodafone.de> ---
(In reply to comment #4)
> Created attachment 83741 [details] [review]
> use more common defaults for the level
>
> This patch adds more common defaults as level. Imho they are likely not
> correct for all the hardware.
Not bad for a first try, but I have some minor comments:
> return true;
> case PIPE_VIDEO_CAP_SUPPORTS_PROGRESSIVE:
> return true;
>+ case PIPE_VIDEO_CAP_MAX_LEVEL:
>+ switch (profile) {
>+ case PIPE_VIDEO_PROFILE_MPEG1:
The new code has a different indention, the radeon code uses tabs instead of
spaces, please fix.
Additional to that you need to fix all drivers to handle the new CAP, just
"grep -R PIPE_VIDEO_CAP_SUPPORTED src/gallium/drivers" to find all those
places.
With that fixed please send the patch to the mesa maillinglist for review.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130807/86b09142/attachment.html>
More information about the dri-devel
mailing list