Can no longer shutdown after drm/radeon: Implement radeon_pci_shutdown

[Deucher, Alexander]

> -----Original Message-----
> From: Peter Chubb [mailto:peter.chubb at nicta.com.au]
> Sent: Wednesday, December 11, 2013 5:11 PM
> To: Markus Trippelsdorf
> Cc: Peter Chubb; Deucher, Alexander; airlied at linux.ie; dri-
> devel at lists.freedesktop.org
> Subject: Re: Can no longer shutdown after drm/radeon: Implement
> radeon_pci_shutdown
> 
> >>>>> "Markus" == Markus Trippelsdorf <markus at trippelsdorf.de> writes:
> 
> Markus> On 2013.12.11 at 11:37 +1100, Peter Chubb wrote:
> 
> Markus> It would be interesting to know where exactly it hangs.  Could
> Markus> you comment out the *_fini(rdev) calls in
> Markus> radeon_driver_unload_kms
> (drivers/gpu/drm/radeon/radeon_kms.c)
> Markus> one after the other to find out which one is responsible?
> 
> It's radeon_device_fini() that is the problem.

I think the problem is that the drm subsystem tears down the device via drm_driver.unload in drm_dev_unregister(), but now that we have a pci_driver.shutdown callback (which is needed for kexec) that gets called too so the driver gets torn down twice.  What exactly happens when you say it's broken?

Alex