[PATCH] drm/exynos: fimd: modify condition in fimd resume

Prathyush K prathyush at chromium.org
Fri Jan 4 02:32:41 PST 2013


Hi,

Please review this patch.

Regards,
Prathyush


On Thu, Dec 27, 2012 at 5:10 PM, Prathyush K <prathyush.k at samsung.com>wrote:

> If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not
> call fimd_activate(false) and just returns. Similarily the check in
> fimd_resume should not resume if previously runtime_suspended.
> Instead the existing check does the opposite. So if fimd was not
> runtime suspended, suspend will turn off fimd but resume will not turn
> it on.  This patch fixes this issue by reversing the condition.
>
> Signed-off-by: Prathyush K <prathyush.k at samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index bf0d9ba..9accd466 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -1046,7 +1046,7 @@ static int fimd_resume(struct device *dev)
>          * of pm runtime would still be 1 so in this case, fimd driver
>          * should be on directly not drawing on pm runtime interface.
>          */
> -       if (pm_runtime_suspended(dev)) {
> +       if (!pm_runtime_suspended(dev)) {
>                 int ret;
>
>                 ret = fimd_activate(ctx, true);
> --
> 1.8.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130104/d66c8a92/attachment.html>


More information about the dri-devel mailing list