[PATCH 1/1] drm/exynos: drm_connector: Fix error check condition

Inki Dae inki.dae at samsung.com
Wed Mar 27 03:36:22 PDT 2013


2013/3/21 Sachin Kamat <sachin.kamat at linaro.org>:
> drm_add_edid_modes() returns 0 upon failure to find any modes.
> Hence check for 0 and not less than 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
> Cc: Rahul Sharma <rahul.sharma at samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c
> index 4c5b685..56ac35f 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
> @@ -124,7 +124,7 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector)
>                 }
>
>                 count = drm_add_edid_modes(connector, edid);
> -               if (count < 0) {
> +               if (count == 0) {

Please just use 'if (!count)'

>                         DRM_ERROR("Add edid modes failed %d\n", count);
>                         goto out;
>                 }
> --
> 1.7.4.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list