[PATCH 1/1] drm/exynos: drm_connector: Fix error check condition

Sachin Kamat sachin.kamat at linaro.org
Wed Mar 27 04:11:06 PDT 2013


On 27 March 2013 16:06, Inki Dae <inki.dae at samsung.com> wrote:
> 2013/3/21 Sachin Kamat <sachin.kamat at linaro.org>:
>> drm_add_edid_modes() returns 0 upon failure to find any modes.
>> Hence check for 0 and not less than 0.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
>> Cc: Rahul Sharma <rahul.sharma at samsung.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_connector.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> index 4c5b685..56ac35f 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c
>> @@ -124,7 +124,7 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector)
>>                 }
>>
>>                 count = drm_add_edid_modes(connector, edid);
>> -               if (count < 0) {
>> +               if (count == 0) {
>
> Please just use 'if (!count)'

Resent the patch with the suggested change.
-- 
With warm regards,
Sachin


More information about the dri-devel mailing list