[PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()
김승우
sw0312.kim at samsung.com
Mon May 20 20:53:39 PDT 2013
Good point,
On 2013년 05월 21일 02:32, Lars-Peter Clausen wrote:
> free_irq() expects the same pointer that was passed to request_threaded_irq(),
> otherwise the IRQ is not freed.
>
> The issue was found using the following coccinelle script:
>
> <smpl>
> @r1@
> type T;
> T devid;
> @@
> request_threaded_irq(..., devid)
>
> @r2@
> type r1.T;
> T devid;
> position p;
> @@
> free_irq at p(..., devid)
>
> @@
> position p != r2.p;
> @@
> *free_irq at p(...)
> </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
Acked-by: Seung-Woo Kim <sw0312.kim at samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index bbfc384..7e99853 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -2082,7 +2082,7 @@ static int hdmi_remove(struct platform_device *pdev)
>
> pm_runtime_disable(dev);
>
> - free_irq(hdata->irq, hdata);
> + free_irq(hdata->irq, ctx);
>
>
> /* hdmiphy i2c driver */
>
--
Seung-Woo Kim
Samsung Software R&D Center
--
More information about the dri-devel
mailing list