[PATCH] drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()

[Inki Dae]

2013/5/21 Lars-Peter Clausen <lars at metafoo.de>

> free_irq() expects the same pointer that was passed to
> request_threaded_irq(),
> otherwise the IRQ is not freed.
>
> The issue was found using the following coccinelle script:
>
> <smpl>
> @r1@
> type T;
> T devid;
> @@
> request_threaded_irq(..., devid)
>
> @r2@
> type r1.T;
> T devid;
> position p;
> @@
> free_irq at p(..., devid)
>
> @@
> position p != r2.p;
> @@
> *free_irq at p(...)
> </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index bbfc384..7e99853 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -2082,7 +2082,7 @@ static int hdmi_remove(struct platform_device *pdev)
>
>         pm_runtime_disable(dev);
>
> -       free_irq(hdata->irq, hdata);
> +       free_irq(hdata->irq, ctx);
>
>
It's better to use devm_reqeust_irq instead. Anyway that was a bug. Applied.

Thanks,
Inki Dae


>
>         /* hdmiphy i2c driver */
> --
> 1.8.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130521/b781136c/attachment.html>