[RFC][PATCH] drm/radeon: put DCE4 audio init/fini in evergreen_hdmi.c

[Alex Deucher]

On Sun, Oct 13, 2013 at 1:06 PM, Rafał Miłecki <zajec5 at gmail.com> wrote:
> 2013/10/13 Alex Deucher <alexdeucher at gmail.com>:
>> On Sun, Oct 13, 2013 at 12:26 PM, Rafał Miłecki <zajec5 at gmail.com> wrote:
>>> That allow us to use registers defined in evergreend.h.
>>> ---
>>> This is another proposal for HDMI code improvment. I'll start testing
>>> my patches soon, so I hope to re-send all of them in the following days.
>>
>> Might be worth adding audio_init/fini callbacks the radeon_asic struct
>> like we dis for hdmi_enable and hdmi_setmode.
>
> Good idea, thanks.
>
>> Might also be worth
>> changing the hdmi_enable and hdmi_setmode callbacks to afmt_enable and
>> afmt_setmode in preparation DP audio support.  Either way, patch looks
>> good to me.
>
> It's a bit too early for me, I'm not sure what part of code can be
> shared between HDMI and DP. On the other hand, I want to clean
> DCE2/3.0/3.2 code too, I'm in progress to collecting the hardware.
>
> Too bad DP monitors/TVs are still so uncommon. Maybe I'll just buy an
> active DP to HDMI adapter, I think it should make the trick.

Audio works pretty much the same between DP and HDMI (IIRC, the use
the same CEA infoframes, etc) so most of the code can be shared.  We
can help clarify things when we get there.  Also, I think maybe only
DCE4 and newer support DP audio (DCE3.2 might, not sure).

Alex