[Bug 77673] [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Apr 20 01:09:37 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=77673

--- Comment #9 from Christian König <deathsimple at vodafone.de> ---
(In reply to comment #8)
> (In reply to comment #6)
> > Please try the attached patch.
> > 
> > We now always use the fixed reference divider if both RADEON_PLL_USE_REF_DIV
> > and RADEON_PLL_USE_FRAC_FB_DIV are set.
> > 
> > If only RADEON_PLL_USE_REF_DIV is set then we only use the fixed value as
> > minimum limit.
> 
> Does that make sense?  Wouldn't we want to use use the fixed value if
> RADEON_PLL_USE_REF_DIV regardless of whether RADEON_PLL_USE_FRAC_FB_DIV is
> set?

I don't really know, it's just the way how the old code handled this.

If RADEON_PLL_USE_REF_DIV was set the RADEON_PLL_USE_FRAC_FB_DIV branch just
used the value as provided, but the none RADEON_PLL_USE_FRAC_FB_DIV branch
still tried to increment the vale.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140420/5bd1396f/attachment.html>


More information about the dri-devel mailing list