[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

[Thierry Reding]

On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote:
> On 22 May 2014 11:51, Sachin Kamat <sachin.kamat at linaro.org> wrote:
> > Hi Rahul,
> [snip]
> >>
> >> +       clk_prepare_enable(ctx->bus_clk);
> >
> > Probably a check for its success?
> >
> >> +       clk_prepare_enable(ctx->lcd_clk);
> >
> 
> Generally we don't check this in any of the driver. It will be
> quite unnecessary.

Then those drivers are all buggy. There's a reason why this function
returns an int rather than void. Just because you've never seen it fail
doesn't mean it can't.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140522/77c462e3/attachment.sig>