[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

Sachin Kamat sachin.kamat at linaro.org
Thu May 22 00:01:28 PDT 2014

On 22 May 2014 12:06, Rahul Sharma <rahul.sharma at samsung.com> wrote:
> On 22 May 2014 11:51, Sachin Kamat <sachin.kamat at linaro.org> wrote:
>> Hi Rahul,
> [snip]
>>> +       clk_prepare_enable(ctx->bus_clk);
>> Probably a check for its success?
>>> +       clk_prepare_enable(ctx->lcd_clk);
> Generally we don't check this in any of the driver. It will be
> quite unnecessary.

However in your case, since you mentioned if the clock is not enabled, it
will hang the system when fimd probe tries to read the register, this check
would ensure it doesn't happen (hang) even if clk_prepare_enable fails for
whatever reasons.

With warm regards,

More information about the dri-devel mailing list