[PATCH libdrm 02/24] radeon: remove empty function declarations

Emil Velikov emil.l.velikov at gmail.com
Wed Apr 1 13:57:40 PDT 2015


On 1 April 2015 at 21:34, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 1 April 2015 at 18:30, Jerome Glisse <j.glisse at gmail.com> wrote:
>> On Wed, Apr 01, 2015 at 05:15:13PM +0100, Emil Velikov wrote:
>>> Missing definition and unused since their introduction.
>>>
>>> Cc: Jerome Glisse <jglisse at redhat.com>
>>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>>
>> NAK
>>
>> I use all this in tools to debug lockup. Best course of action is to
>> exclude bof.h from being distributed. My tools static link and i just
>> point them to libdrm git tree.
>>
> Did not notice any mention of such out-of-tree tools in the commit
> that introduced these functions, so I've naively assumed that they are
> unused.
Scratch that - I'm blind.

Upon closer look at your radeondb repo, I cannot see any static
linking in there. Also it seems that some of the functionality is
duplicated between the two. With the radeondb version being out of
date :'(

-Emil


More information about the dri-devel mailing list