[PATCH v2] modetest: initialize handles/pitches in set_plane()
Emil Velikov
emil.l.velikov at gmail.com
Tue Apr 21 13:10:04 PDT 2015
Hi Tobias,
On 20/04/15 19:50, Tobias Jakobi wrote:
> Only the 'offsets' array was initialized to zero.
> Since bo_create only sets the handles which are
> necessary, were we passing garbage data to the
> kernel when calling drmModeAddFB2 later.
>
> The issue only seems to appear when passing e.g.
> NV12 data to the kernel, a case where not only
> handles[0] is used. I therefore also removed the
> corresponding comment.
>
> v2: Do the same for set_mode(), set_cursors()
> and test_page_flip().
>
Nice catch. I will push this in a day or so, unless someone objects.
This and the other patches from Joonyoung Shim make me question how many
people have seriously used this tool.
Thanks
Emil
More information about the dri-devel
mailing list