[PATCH v2] modetest: initialize handles/pitches in set_plane()

Ilia Mirkin imirkin at alum.mit.edu
Tue Apr 21 12:15:59 PDT 2015


On Tue, Apr 21, 2015 at 4:10 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Tobias,
>
> On 20/04/15 19:50, Tobias Jakobi wrote:
>> Only the 'offsets' array was initialized to zero.
>> Since bo_create only sets the handles which are
>> necessary, were we passing garbage data to the
>> kernel when calling drmModeAddFB2 later.
>>
>> The issue only seems to appear when passing e.g.
>> NV12 data to the kernel, a case where not only
>> handles[0] is used. I therefore also removed the
>> corresponding comment.
>>
>> v2: Do the same for set_mode(), set_cursors()
>>     and test_page_flip().
>>
> Nice catch. I will push this in a day or so, unless someone objects.
>
> This and the other patches from Joonyoung Shim make me question how many
> people have seriously used this tool.

I know it was immensely useful to me when I was adding YUV plane
support to nouveau. Seemed to work as advertised at the time (1.5y
ago) for YUYV, UYVY, and NV12.

  -ilia


More information about the dri-devel mailing list