[PATCH] drm: tda998x: Change cec_write address type

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Jan 9 08:56:30 PST 2015


On Wed, Jan 07, 2015 at 09:42:19AM +0100, Jean-Francois Moine wrote:
> The CEC registers of the TDA998x have no access by page,
> so, a 8 bits address is enough.
> 
> Signed-off-by: Jean-Francois Moine <moinejf at free.fr>
> ---
>  drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index d476279..70658af 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -342,7 +342,7 @@ struct tda998x_priv {
>  #define TDA19988                  0x0301
>  
>  static void
> -cec_write(struct tda998x_priv *priv, uint16_t addr, uint8_t val)
> +cec_write(struct tda998x_priv *priv, uint8_t addr, uint8_t val)

I'm not bothered by this change - is there a pressing reason to make it?

Looking at the generated code, this change will be a no-op, so it's purely
cosmetic from what I can determine.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list