[PATCH] drm: tda998x: Change cec_write address type

Jean-Francois Moine moinejf at free.fr
Fri Jan 9 09:24:03 PST 2015


On Fri, 9 Jan 2015 16:56:30 +0000
Russell King - ARM Linux <linux at arm.linux.org.uk> wrote:

> > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> > index d476279..70658af 100644
> > --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> > @@ -342,7 +342,7 @@ struct tda998x_priv {
> >  #define TDA19988                  0x0301
> >  
> >  static void
> > -cec_write(struct tda998x_priv *priv, uint16_t addr, uint8_t val)
> > +cec_write(struct tda998x_priv *priv, uint8_t addr, uint8_t val)  
> 
> I'm not bothered by this change - is there a pressing reason to make it?
> 
> Looking at the generated code, this change will be a no-op, so it's purely
> cosmetic from what I can determine.

Yes. It is just to have the same addr type in cec_read and cec_write.

-- 
Ken ar c'hentaƱ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/


More information about the dri-devel mailing list