[PATCH 1/2] drm/udl: optimize udl_compress_hline16

Dave Airlie airlied at gmail.com
Thu Jan 29 19:45:51 PST 2015


On 29 January 2015 at 07:41, Haixia Shi <hshi at chromium.org> wrote:
> The run-length encoding algorithm should compare 16-bit encoded pixel
> values instead of comparing raw pixel values. It allows pixels
> with similar but different colors to be encoded as repeat pixels, and
> thus potentially save USB bandwidth.

This fails to build here, are we missing some precursor patches?

 CC [M]  drivers/gpu/drm/udl/udl_transfer.o
/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:
In function ‘get_pixel_val16’:
/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:91:3:
error: implicit declaration of function ‘pixel32_to_be16p’
[-Werror=implicit-function-declaration]
   pixel_val16 = pixel32_to_be16p(pixel);
   ^
/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:
In function ‘udl_compress_hline16’:
/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:180:33:
error: ‘start’ undeclared (first use in this function)
     *raw_pixels_count_byte = (((start -
                                 ^
/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:180:33:
note: each undeclared identifier is reported only once for each
function it appears in
cc1: some warnings being treated as errors

Dave.


More information about the dri-devel mailing list