[PATCH 1/2] drm/udl: optimize udl_compress_hline16

[Haixia Shi]

Dave

Sorry it seems that my patch was rebased on top of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

I'm going to re-send the patch on top of the drm-next branch of your
tree (git://people.freedesktop.org/~airlied/linux)

On Thu, Jan 29, 2015 at 7:45 PM, Dave Airlie <airlied at gmail.com> wrote:
> On 29 January 2015 at 07:41, Haixia Shi <hshi at chromium.org> wrote:
>> The run-length encoding algorithm should compare 16-bit encoded pixel
>> values instead of comparing raw pixel values. It allows pixels
>> with similar but different colors to be encoded as repeat pixels, and
>> thus potentially save USB bandwidth.
>
> This fails to build here, are we missing some precursor patches?
>
>  CC [M]  drivers/gpu/drm/udl/udl_transfer.o
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:
> In function ‘get_pixel_val16’:
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:91:3:
> error: implicit declaration of function ‘pixel32_to_be16p’
> [-Werror=implicit-function-declaration]
>    pixel_val16 = pixel32_to_be16p(pixel);
>    ^
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:
> In function ‘udl_compress_hline16’:
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:180:33:
> error: ‘start’ undeclared (first use in this function)
>      *raw_pixels_count_byte = (((start -
>                                  ^
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/udl/udl_transfer.c:180:33:
> note: each undeclared identifier is reported only once for each
> function it appears in
> cc1: some warnings being treated as errors
>
> Dave.