[PATCH 4/4] drm/sti: atomic crtc/plane update
Emil Velikov
emil.l.velikov at gmail.com
Fri Jul 31 05:22:36 PDT 2015
Hello Vincent,
On 31 July 2015 at 11:13, Vincent Abriou <vincent.abriou at st.com> wrote:
> Better fit STI hardware structure.
> Planes are no more responsible of updating mixer information such
> as z-order and status. It is now up to the CRTC atomic flush to
> do it. Plane actions (enable or disable) are performed atomically.
> Disabling of a plane is synchronize with the vsync event.
>
> Signed-off-by: Vincent Abriou <vincent.abriou at st.com>
> Reviewed-by: Benjamin Gaignard <benjamin.gaignard at linaro.org>
> ---
> drivers/gpu/drm/sti/sti_compositor.c | 32 +--
> drivers/gpu/drm/sti/sti_crtc.c | 120 +++++++--
> drivers/gpu/drm/sti/sti_cursor.c | 211 +++++++++------
> drivers/gpu/drm/sti/sti_cursor.h | 6 +-
> drivers/gpu/drm/sti/sti_gdp.c | 493 +++++++++++++++++++----------------
> drivers/gpu/drm/sti/sti_gdp.h | 8 +-
> drivers/gpu/drm/sti/sti_hqvdp.c | 429 ++++++++++++++++--------------
> drivers/gpu/drm/sti/sti_mixer.h | 10 +-
> drivers/gpu/drm/sti/sti_plane.c | 251 +-----------------
> drivers/gpu/drm/sti/sti_plane.h | 66 ++---
> drivers/gpu/drm/sti/sti_vid.c | 29 ++-
> drivers/gpu/drm/sti/sti_vid.h | 5 +-
> 12 files changed, 808 insertions(+), 852 deletions(-)
>
Just a friendly note - other drivers transitioning to atomics have
done so in a more gradual manner. I believe the idea/intent was to
ensure commits are simple and straightforward enough to minimise the
cases of regressions/bugs.
Either way the decision is between you and the driver maintainer.
Speaking of which there isn't one listed in MAINTAINERS. Is that
intentional ?
Cheers,
Emil
More information about the dri-devel
mailing list