[PATCH 4/4] drm/sti: atomic crtc/plane update

[Benjamin Gaignard]

Hello Emil,

This series of patches is the second step to convert sit driver to atomic,
I have the first step few weeks ago.
This time we really take benefit of the atomic helpers to make match
correctly code and hardware split. To give you an example, before
those patches, we were calling code driving hardware planes while
setting crtc hardware...

I agree that is a big change but we can to less then that to keep
everything working.
We have done quite many tests with modetest and weston to be sure we
do not have regressions.

Both Vincent and I should be put in MAINTAINERS file, I will do a
patch for that.

Regards,
Benjamin


2015-07-31 14:22 GMT+02:00 Emil Velikov <emil.l.velikov at gmail.com>:
> Hello Vincent,
>
> On 31 July 2015 at 11:13, Vincent Abriou <vincent.abriou at st.com> wrote:
>> Better fit STI hardware structure.
>> Planes are no more responsible of updating mixer information such
>> as z-order and status. It is now up to the CRTC atomic flush to
>> do it. Plane actions (enable or disable) are performed atomically.
>> Disabling of a plane is synchronize with the vsync event.
>>
>> Signed-off-by: Vincent Abriou <vincent.abriou at st.com>
>> Reviewed-by: Benjamin Gaignard <benjamin.gaignard at linaro.org>
>> ---
>>  drivers/gpu/drm/sti/sti_compositor.c |  32 +--
>>  drivers/gpu/drm/sti/sti_crtc.c       | 120 +++++++--
>>  drivers/gpu/drm/sti/sti_cursor.c     | 211 +++++++++------
>>  drivers/gpu/drm/sti/sti_cursor.h     |   6 +-
>>  drivers/gpu/drm/sti/sti_gdp.c        | 493 +++++++++++++++++++----------------
>>  drivers/gpu/drm/sti/sti_gdp.h        |   8 +-
>>  drivers/gpu/drm/sti/sti_hqvdp.c      | 429 ++++++++++++++++--------------
>>  drivers/gpu/drm/sti/sti_mixer.h      |  10 +-
>>  drivers/gpu/drm/sti/sti_plane.c      | 251 +-----------------
>>  drivers/gpu/drm/sti/sti_plane.h      |  66 ++---
>>  drivers/gpu/drm/sti/sti_vid.c        |  29 ++-
>>  drivers/gpu/drm/sti/sti_vid.h        |   5 +-
>>  12 files changed, 808 insertions(+), 852 deletions(-)
>>
> Just a friendly note - other drivers transitioning to atomics have
> done so in a more gradual manner. I believe the idea/intent was to
> ensure commits are simple and straightforward enough to minimise the
> cases of regressions/bugs.
>
> Either way the decision is between you and the driver maintainer.
> Speaking of which there isn't one listed in MAINTAINERS. Is that
> intentional ?
>
> Cheers,
> Emil



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog