[PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings

Julia Lawall julia.lawall at lip6.fr
Fri Apr 15 07:15:49 UTC 2016


Move constants to the right of binary operators.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
Signed-off-by: Julia Lawall <julia.lawall at lip6.fr>
---

Could be nice to put the thing being tested first.

 amdgpu_grph_object_id_helpers.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_grph_object_id_helpers.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_grph_object_id_helpers.c
@@ -169,11 +169,11 @@ struct graphics_object_id amdgpu_object_
 	struct graphics_object_id go_id = { 0 };
 
 	type = object_type_from_bios_object_id(bios_object_id);
-	if (OBJECT_TYPE_UNKNOWN == type)
+	if (type == OBJECT_TYPE_UNKNOWN)
 		return go_id;
 
 	enum_id = enum_id_from_bios_object_id(bios_object_id);
-	if (ENUM_ID_UNKNOWN == enum_id)
+	if (enum_id == ENUM_ID_UNKNOWN)
 		return go_id;
 
 	go_id = display_graphics_object_id_init(


More information about the dri-devel mailing list