[PATCH libdrm 3/3] xf86drm: don't fatal on per device error in drmGetDevice[s]2

Emil Velikov emil.l.velikov at gmail.com
Mon Dec 12 14:12:28 UTC 2016


On 10 December 2016 at 05:52, Jonathan Gray <jsg at jsg.id.au> wrote:
> When iterating over all the device nodes if drmProcessPciDevice()
> returned an error for any node the function would return an error,
> ignoring any valid nodes.
>
> The result of this on OpenBSD where drmProcessPciDevice() results in
> device nodes being opened to issue ioctls to get pci data
> was that data obtained from /dev/drm0 would be ignored if /dev/drm1
> could not be opened.
>
Out of curiosity - did you actually hit such an issue or you've
spotted it by observation ?
I'm not too sure which route is the "correct" one here, but I believe
you got it spot on.

I'll push this alongside v2 of 1/3 and 2/3.

Thanks !
Emil


More information about the dri-devel mailing list