[PATCH libdrm 3/3] xf86drm: don't fatal on per device error in drmGetDevice[s]2

Jonathan Gray jsg at jsg.id.au
Mon Dec 12 14:55:31 UTC 2016


On Mon, Dec 12, 2016 at 02:12:28PM +0000, Emil Velikov wrote:
> On 10 December 2016 at 05:52, Jonathan Gray <jsg at jsg.id.au> wrote:
> > When iterating over all the device nodes if drmProcessPciDevice()
> > returned an error for any node the function would return an error,
> > ignoring any valid nodes.
> >
> > The result of this on OpenBSD where drmProcessPciDevice() results in
> > device nodes being opened to issue ioctls to get pci data
> > was that data obtained from /dev/drm0 would be ignored if /dev/drm1
> > could not be opened.
> >
> Out of curiosity - did you actually hit such an issue or you've
> spotted it by observation ?
> I'm not too sure which route is the "correct" one here, but I believe
> you got it spot on.
> 
> I'll push this alongside v2 of 1/3 and 2/3.
> 
> Thanks !
> Emil

Currently by default on login we change ownership of /dev/drm0 via
fbtab when a user logs in on a glass console but no other /dev/drm
nodes.

I saw this before the OpenBSD specific path was added and was reminded
of it when testing one of the functions that isn't used by Mesa yet.


More information about the dri-devel mailing list