[PATCH 4/4] drm/layerscape: Add HDMI driver for freescale DCU

[Meng Yi]

Hi Rob
    Thanks for your reply. I will correct those soon, and then send v2 out.
BR
Meng Yi

> On Friday, January 29, 2016 10:52 AM, Rob Herring[robh at kernel.org] wrote:

> > +The SiI9022A is an ultra low-power HDMI transmitter. It supports
> > +resolutions from standard definition 480i/p and 576i/p all the way to
> > +high-definition 720p, 1080i, and 1080p, the highest resolution
> > +supported by HDTVs today. It also supports all
> 
> Well, we're up to 4K now...

> > +            ports {
> > +                    #address-cells = <1>;
> > +                    #size-cells = <0>;
> > +
> > +                    port at 0 {
> > +                            reg = <1>;
> 
> Your unit address (0) and reg don't match.
> 
> > +                            sii9022_out: endpoint {
> > +                                    remote-endpoint = <&hdmi_con>;
> > +                            };
> 
> This needs to have a port for the input for the connection to your display
> controller.
> 
> > +                    };
> > +            };
> > +    };