[PATCH v3 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support

Tomasz Figa tfiga at chromium.org
Wed Jun 15 09:25:59 UTC 2016


Hi Yakir,

Yakir Yang <ykk <at> rock-chips.com> writes:
> >>   Required properties:
> >> -- compatible: "rockchip,rk3288-edp";
> >> +- compatible: "rockchip,rk3288-edp",
> >> +             "rockchip,rk3399-edp";
> > As commented by Tomasz on gerrit, there is a pre-existing typo here.
> > Specifically "rockchip,rk3288-edp" should be "rockchip,rk3288-dp".
> >
> > The typo is pre-existing so I'm not sure you would need to spin this
> > series to fix it, but if you were spinning it anyway it wouldn't hurt
> > to fix.  Could also just send out a followon patch to fix this after
> > the series lands...
> 
> My bad, forget to fix that :(
> it would be better to merge that fix into this series, would send a 
> follow patch soon.

No need to respin the whole series just for this typo. It's better to fix it 
in a separate patch later at this point, especially since this revision of 
the series looks quite good.

Best regards,
Tomasz




More information about the dri-devel mailing list