[PATCH v3 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support
Yakir Yang
ykk at rock-chips.com
Thu Jun 16 02:16:32 UTC 2016
Tomasz,
On 06/15/2016 05:25 PM, Tomasz Figa wrote:
> Hi Yakir,
>
> Yakir Yang <ykk <at> rock-chips.com> writes:
>>>> Required properties:
>>>> -- compatible: "rockchip,rk3288-edp";
>>>> +- compatible: "rockchip,rk3288-edp",
>>>> + "rockchip,rk3399-edp";
>>> As commented by Tomasz on gerrit, there is a pre-existing typo here.
>>> Specifically "rockchip,rk3288-edp" should be "rockchip,rk3288-dp".
>>>
>>> The typo is pre-existing so I'm not sure you would need to spin this
>>> series to fix it, but if you were spinning it anyway it wouldn't hurt
>>> to fix. Could also just send out a followon patch to fix this after
>>> the series lands...
>> My bad, forget to fix that :(
>> it would be better to merge that fix into this series, would send a
>> follow patch soon.
> No need to respin the whole series just for this typo. It's better to fix it
> in a separate patch later at this point, especially since this revision of
> the series looks quite good.
Okay,
BR,
- Yakir
> Best regards,
> Tomasz
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
More information about the dri-devel
mailing list