[PATCH 21/22] arm64: dts: msm8916: Add display support

[Archit Taneja]

On 6/20/2016 6:34 PM, Rob Herring wrote:
> On Thu, Jun 16, 2016 at 05:06:46PM +0530, Archit Taneja wrote:
>> The MSM8916 SoC contains a MDP5 based display block, and one DSI output.
>> Add the top level MDSS DT node, and the MDP5, DSI and DSI PHY children
>> sub-blocks. Establish the link between MDP5's INTF1 output port and DSI's
>> input port.
>>
>> Cc: Andy Gross <andy.gross at linaro.org>
>> Cc: Rob Herring <robh at kernel.org>
>> Cc: devicetree at vger.kernel.org
>>
>> Signed-off-by: Archit Taneja <architt at codeaurora.org>
>> ---
>>   arch/arm64/boot/dts/qcom/msm8916.dtsi | 120 ++++++++++++++++++++++++++++++++++
>>   1 file changed, 120 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> index 9681200..d8cccfc 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
>
>> +
>> +			dsi0: dsi at 1a98000 {
>> +				compatible = "qcom,mdss-dsi-ctrl";
>> +				qcom,dsi-host-index = <0>;
>
> How is this used? It should really go.

It's supposed to tell the driver which instance # of DSI block it is.
The DSI display bindings on OMAP also had the same issue. It was
dealt with by keeping a copy of the starting MMIO address of each
DSI instance for every supported SoC in the driver, and figure out
which DSI instance the device was through that.

I could do the same here (and drop a similar property for DSI PHY
too). Do you have any suggestions on how the driver could figure
which instance the device is without indirectly figuring out
through some other property?

Thanks for the reviews.

Archit

>
> Rob
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project