[PATCH] drm/amd/powerplay: fix memory leak on tdp_table

Colin King colin.king at canonical.com
Mon Mar 21 22:47:14 UTC 2016


From: Colin Ian King <colin.king at canonical.com>

tdp_table is being leaked on an error exit return path,
fix this by kfree'ing it.  Also swap comparison around to make the
patch warning free with checkpatch.

Leak found via static analysis with CoverityScan

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c
index 34f4bef..40b7679 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c
@@ -512,8 +512,10 @@ static int get_cac_tdp_table(
 
 	hwmgr->dyn_state.cac_dtp_table = kzalloc(table_size, GFP_KERNEL);
 
-	if (NULL == hwmgr->dyn_state.cac_dtp_table)
+	if (hwmgr->dyn_state.cac_dtp_table == NULL) {
+		kfree(tdp_table);
 		return -ENOMEM;
+	}
 
 	memset(hwmgr->dyn_state.cac_dtp_table, 0x00, table_size);
 
-- 
2.7.3



More information about the dri-devel mailing list