[PATCH] drm/amd/powerplay: mark symbols static where possible

[Baoyou Xie]

On 25 October 2016 at 16:15, Arnd Bergmann <arnd at arndb.de> wrote:

> On Tuesday, October 25, 2016 10:31:21 AM CEST Baoyou Xie wrote:
> > On 25 October 2016 at 04:51, Arnd Bergmann <arnd at arndb.de> wrote:
> > > On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> > > The function has no callers, so the easiest way would be to remove it
> > > entirely, but it's possible that there are plans to add users soon.
> > >
> > > It was assumed that this function will be used soon, so this patch
> remains
> > it.
> > if it still not be used in 4.10, then we can remove it.
> > is it right?
>
> There is no such rule in general, it's up to the maintainer and
> it depends on the specific reason for why the function ended up
> being unused in the first place.
>
> However, we can expect the maintainer to come up with some solution
> to address the warning. Possible options include:
>
> - calling the function from where it was meant to be used
> - removing the function
> - adding __maybe_unused
> - adding an #if 0
>
> I have not looked at this specific example and do not know
> which of them would be appropriate here. If you look at the
> output of 'git log -p drivers/gpu/drm/amd/amdgpu/../
> powerplay/hwmgr/smu7_hwmgr.c'
> you might find it out yourself.
>
>
Good idea :)

hi, Daniel:
    could you tell me the git tree that you use? it's better to work on
your git tree.

        Arnd
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161025/87a8f6d9/attachment.html>