[PATCH 1/2] drm: Distinguish no name from ENOMEM in set_unique()

[Daniel Vetter]

On Wed, Sep 21, 2016 at 04:59:18PM +0200, Tom Gundersen wrote:
> If passing name == NULL to drm_drv_set_unique() we now get -ENOMEM
> as kstrdup() returns NULL. Instead check for this explicitly and
> return -EINVAL if no name is provided.
> 
> Signed-off-by: Tom Gundersen <teg at jklm.no>

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> ---
>  drivers/gpu/drm/drm_drv.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index f2f6429..99e6751 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -338,6 +338,9 @@ void drm_minor_release(struct drm_minor *minor)
>  
>  static int drm_dev_set_unique(struct drm_device *dev, const char *name)
>  {
> +	if (!name)
> +		return -EINVAL;
> +
>  	kfree(dev->unique);
>  	dev->unique = kstrdup(name, GFP_KERNEL);
>  
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch