[PATCH 1/2] drm: Distinguish no name from ENOMEM in set_unique()

[Emil Velikov]

On 21 September 2016 at 15:59, Tom Gundersen <teg at jklm.no> wrote:
> If passing name == NULL to drm_drv_set_unique() we now get -ENOMEM
> as kstrdup() returns NULL. Instead check for this explicitly and
> return -EINVAL if no name is provided.
>
> Signed-off-by: Tom Gundersen <teg at jklm.no>
> ---
>  drivers/gpu/drm/drm_drv.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index f2f6429..99e6751 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -338,6 +338,9 @@ void drm_minor_release(struct drm_minor *minor)
>
>  static int drm_dev_set_unique(struct drm_device *dev, const char *name)
>  {
> +       if (!name)
> +               return -EINVAL;
> +
>From memory there should be no open-source drivers where this happens
today. Either way, having a big WARN/OOPS would be better, imho, since
it will point to the driver bug/issue (?).

Regards,
Emil