[PATCH] drm/ttm: cleanup unuse ret value

Alex Deucher alexdeucher at gmail.com
Mon Apr 17 15:42:18 UTC 2017


On Mon, Apr 17, 2017 at 3:38 AM, Huang Rui <ray.huang at amd.com> wrote:
> The ret must be 0 here, otherwise, the function will return after init_mem_type.
>
> Signed-off-by: Huang Rui <ray.huang at amd.com>

I think you can drop the initial assignment of ret as well.  Either way:

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/ttm/ttm_bo.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 9ee4ff4..5dcb4e1 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1440,7 +1440,6 @@ int ttm_bo_init_mm(struct ttm_bo_device *bdev, unsigned type,
>                 return ret;
>         man->bdev = bdev;
>
> -       ret = 0;
>         if (type != TTM_PL_SYSTEM) {
>                 ret = (*man->func->init)(man, p_size);
>                 if (ret)
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list