[PATCH] drm/ttm: cleanup unuse ret value

Huang Rui ray.huang at amd.com
Tue Apr 18 01:02:05 UTC 2017


On Mon, Apr 17, 2017 at 11:42:18PM +0800, Alex Deucher wrote:
> On Mon, Apr 17, 2017 at 3:38 AM, Huang Rui <ray.huang at amd.com> wrote:
> > The ret must be 0 here, otherwise, the function will return after
> init_mem_type.
> >
> > Signed-off-by: Huang Rui <ray.huang at amd.com>
> 
> I think you can drop the initial assignment of ret as well.  Either way:
> 
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> 

Yep, we needn't set ret as EINVAL at first, because it must be assigned
before return.

Thanks,
Rui


More information about the dri-devel mailing list